third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 1416793005: Devtools: API To set the red/yellow squiggles for a file via DI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1416793005: Devtools: API To set the red/yellow squiggles for a file via DI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update API with feedback from cl Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index d13fd1ae314352c1bf269004caab5212c3482605..bd33d94dec978e5925e6a81b9f35f3903eb5bf4c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -393,7 +393,10 @@ WebInspector.JavaScriptSourceFrame.prototype = {

var compileError = errorData.compileError;

if (compileError) {

var messageText = WebInspector.UIString("LiveEdit compile failed: %s", compileError.message);

- var message = new WebInspector.SourceFrameMessage(messageText, WebInspector.SourceFrameMessage.Level.Error, compileError.lineNumber - 1, compileError.columnNumber + 1);

+ var startLine = compileError.lineNumber - 1;

+ var endLine = compileError.columnNumber + 1;

+ var location = new WebInspector.TextRange(startLine, endLine, startLine, endLine);

+ var message = new WebInspector.SourceFrameMessage(messageText, WebInspector.UISourceCodeMessage.Level.Error, location);

this.addMessageToSource(message);

} else {

WebInspector.console.addMessage(WebInspector.UIString("Unknown LiveEdit error: %s; %s", JSON.stringify(errorData), error), warningLevel);