| Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
|
| diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
|
| index 41f0c36a1617b36ac4c40ebb088ad0a310b3b9f5..96d91d4160cbe15336cb6e42c64b59542b0f3d3d 100644
|
| --- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
|
| +++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
|
| @@ -690,15 +690,13 @@ WebInspector.SourceFrame.prototype = {
|
| * @constructor
|
| * @param {string} messageText
|
| * @param {!WebInspector.SourceFrameMessage.Level} level
|
| - * @param {number} lineNumber
|
| - * @param {number=} columnNumber
|
| + * @param {!WebInspector.TextRange} range
|
| */
|
| -WebInspector.SourceFrameMessage = function(messageText, level, lineNumber, columnNumber)
|
| +WebInspector.SourceFrameMessage = function(messageText, level, range)
|
| {
|
| this._messageText = messageText;
|
| this._level = level;
|
| - this._lineNumber = lineNumber;
|
| - this._columnNumber = columnNumber;
|
| + this._range = range;
|
| }
|
|
|
| /**
|
| @@ -719,7 +717,8 @@ WebInspector.SourceFrameMessage.fromConsoleMessage = function(consoleMessage, li
|
| {
|
| console.assert(consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Warning);
|
| var level = consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error ? WebInspector.SourceFrameMessage.Level.Error : WebInspector.SourceFrameMessage.Level.Warning;
|
| - return new WebInspector.SourceFrameMessage(consoleMessage.messageText, level, lineNumber, columnNumber);
|
| + var location = new WebInspector.TextRange(lineNumber, columnNumber, lineNumber, columnNumber);
|
| + return new WebInspector.SourceFrameMessage(consoleMessage.messageText, level, location);
|
| }
|
|
|
| WebInspector.SourceFrameMessage.prototype = {
|
| @@ -740,11 +739,19 @@ WebInspector.SourceFrameMessage.prototype = {
|
| },
|
|
|
| /**
|
| + * @return {!WebInspector.TextRange}
|
| + */
|
| + range: function()
|
| + {
|
| + return this._range;
|
| + },
|
| +
|
| + /**
|
| * @return {number}
|
| */
|
| lineNumber: function()
|
| {
|
| - return this._lineNumber;
|
| + return this._range.startLine;
|
| },
|
|
|
| /**
|
| @@ -752,7 +759,7 @@ WebInspector.SourceFrameMessage.prototype = {
|
| */
|
| columnNumber: function()
|
| {
|
| - return this._columnNumber;
|
| + return this._range.startColumn;
|
| },
|
|
|
| /**
|
| @@ -761,7 +768,9 @@ WebInspector.SourceFrameMessage.prototype = {
|
| */
|
| isEqual: function(another)
|
| {
|
| - return this.messageText() === another.messageText() && this.level() === another.level() && this.lineNumber() === another.lineNumber() && this.columnNumber() === another.columnNumber();
|
| + return this.messageText() === another.messageText() &&
|
| + this.level() === another.level() &&
|
| + this.range().equal(another.range());
|
| }
|
| }
|
|
|
| @@ -866,6 +875,8 @@ WebInspector.SourceFrame.RowMessageBucket.prototype = {
|
| var base = this._textEditor.cursorPositionToCoordinates(lineNumber, 0);
|
|
|
| var start = this._textEditor.cursorPositionToCoordinates(lineNumber, Math.max(columnNumber - 1, lineIndent));
|
| + if (!start)
|
| + return; //stale data - columnNumber is already gone, wait for future update and for UI to settle
|
| var end = this._textEditor.cursorPositionToCoordinates(lineNumber, lineText.length);
|
| /** @const */
|
| var codeMirrorLinesLeftPadding = 4;
|
|
|