Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416793004: Remove support for -webkit-canvas and Document.getCSSCanvasContext. (Closed)

Created:
5 years, 2 months ago by chrishtr
Modified:
5 years, 2 months ago
Reviewers:
pdr., boliu, Justin Novosad
CC:
darktears, android-webview-reviews_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Rik, Inactive, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof, vivekg_samsung, vivekg, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for -webkit-canvas and Document.getCSSCanvasContext. BUG=475655 Committed: https://crrev.com/24e58b0d8fab28fa20e69f191d833fe97aaff75d Cr-Commit-Position: refs/heads/master@{#355906}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 15

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1191 lines) Patch
M android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/compositing/masks/layer-mask-placement.html View 1 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/masks/layer-mask-placement-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-as-image.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-as-image-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-as-image-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-as-image-incremental-repaint.html View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-as-image-incremental-repaint-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-expected.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-multiple-removal.html View 1 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-multiple-removal-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-zoom.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-zoom-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-bg-zoom-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-css-crazy.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-css-crazy-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/crash-set-font.html View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/crash-set-font-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/webgl/css-webkit-canvas.html View 1 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/webgl/css-webkit-canvas-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/webgl/css-webkit-canvas-repaint.html View 1 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/fill-layer-crash.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/content-url-canvas.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/content-url-canvas-expected.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/canvas/webgl/css-webkit-canvas-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/canvas/webgl/css-webkit-canvas-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/canvas/webgl/css-webkit-canvas-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-as-image-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/ManualTests/animated-canvas-as-background.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/ManualTests/canvas-mask-redraw.html View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/CSSCanvasValue.h View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/core/css/CSSCanvasValue.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 7 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.cpp View 6 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 4 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 2 3 4 5 5 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 3 4 5 8 chunks +2 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.css View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.js View 2 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 3 4 2 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
chrishtr
5 years, 2 months ago (2015-10-23 17:58:36 UTC) #3
Justin Novosad
Party time! https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/css/CSSCanvasValue.h File third_party/WebKit/Source/core/css/CSSCanvasValue.h (left): https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/css/CSSCanvasValue.h#oldcode36 third_party/WebKit/Source/core/css/CSSCanvasValue.h:36: class CSSCanvasValue : public CSSImageGeneratorValue { So ...
5 years, 2 months ago (2015-10-23 18:21:12 UTC) #4
pdr.
woohoooo! https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/dom/Document.h File third_party/WebKit/Source/core/dom/Document.h (left): https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/dom/Document.h#oldcode816 third_party/WebKit/Source/core/dom/Document.h:816: // Extension for manipulating canvas drawing contexts for ...
5 years, 2 months ago (2015-10-23 18:23:55 UTC) #5
chrishtr
https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/css/CSSCanvasValue.h File third_party/WebKit/Source/core/css/CSSCanvasValue.h (left): https://codereview.chromium.org/1416793004/diff/60001/third_party/WebKit/Source/core/css/CSSCanvasValue.h#oldcode36 third_party/WebKit/Source/core/css/CSSCanvasValue.h:36: class CSSCanvasValue : public CSSImageGeneratorValue { On 2015/10/23 at ...
5 years, 2 months ago (2015-10-23 19:47:07 UTC) #6
Justin Novosad
Sooooo lgtm
5 years, 2 months ago (2015-10-23 19:52:51 UTC) #7
pdr.
Don't let the door hit ya' on the way out, -webkit-canvas. LGTM
5 years, 2 months ago (2015-10-23 19:56:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416793004/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416793004/90001
5 years, 2 months ago (2015-10-23 19:58:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112328)
5 years, 2 months ago (2015-10-23 20:07:23 UTC) #12
chrishtr
Bo, need a stamp for android_webview/tools/
5 years, 2 months ago (2015-10-23 20:11:14 UTC) #14
boliu
cc timvolodine rs lgtm
5 years, 2 months ago (2015-10-23 20:12:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416793004/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416793004/90001
5 years, 2 months ago (2015-10-23 20:20:30 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 2 months ago (2015-10-23 22:27:43 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 22:28:29 UTC) #19
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/24e58b0d8fab28fa20e69f191d833fe97aaff75d
Cr-Commit-Position: refs/heads/master@{#355906}

Powered by Google App Engine
This is Rietveld 408576698