Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: test/cctest/test-parsing.cc

Issue 1416753009: [parser] early error when declaration Pattern missing Initializer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/preparser.cc ('k') | test/message/const-decl-no-init.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index ec5d5f9d9badc157b88a26b9e543642ccd5b0712..1c4a3c14cb94037a659cf2d4a9ec6f030efc441a 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -6702,6 +6702,33 @@ TEST(DestructuringNegativeTests) {
RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
arraysize(always_flags));
}
+
+ { // Declaration-specific errors
+ const char* context_data[][2] = {{"'use strict'; var ", ""},
+ {"'use strict'; let ", ""},
+ {"'use strict'; const ", ""},
+ {"'use strict'; for (var ", ";;) {}"},
+ {"'use strict'; for (let ", ";;) {}"},
+ {"'use strict'; for (const ", ";;) {}"},
+ {"var ", ""},
+ {"let ", ""},
+ {"const ", ""},
+ {"for (var ", ";;) {}"},
+ {"for (let ", ";;) {}"},
+ {"for (const ", ";;) {}"},
+ {NULL, NULL}};
+
+ // clang-format off
+ const char* data[] = {
+ "{ a }",
+ "[ a ]",
+ NULL};
+ // clang-format on
+ static const ParserFlag always_flags[] = {kAllowHarmonyDestructuring,
+ kAllowHarmonySloppyLet};
+ RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
+ arraysize(always_flags));
+ }
}
@@ -7188,13 +7215,13 @@ TEST(LetSloppyOnly) {
"for (var [let] = 1; let < 1; let++) {}",
"for (var [let] in {}) {}",
"var let",
- "var [let]",
+ "var [let] = []",
"for (const let = 1; let < 1; let++) {}",
"for (const let in {}) {}",
"for (const [let] = 1; let < 1; let++) {}",
"for (const [let] in {}) {}",
"const let",
- "const [let]",
+ "const [let] = []",
NULL
};
// clang-format on
« no previous file with comments | « src/preparser.cc ('k') | test/message/const-decl-no-init.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698