[parser] early error when declaration Pattern missing Initializer

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parser.h"
 
 #include "src/api.h"
 #include "src/ast.h"
 #include "src/ast-literal-reindexer.h"
 #include "src/bailout-reason.h"
@@ skipping 2514 matching lines @@
   int bindings_start = peek_position();
   bool is_for_iteration_variable;
   do {
     if (fni_ != NULL) fni_->Enter();
 
     // Parse name.
     if (!first_declaration) Consume(Token::COMMA);
 
     Expression* pattern;
     {
+      int decl_pos = peek_position();
       ExpressionClassifier pattern_classifier;
       Token::Value next = peek();
       pattern = ParsePrimaryExpression(&pattern_classifier, ok);
       if (!*ok) return;
       ValidateBindingPattern(&pattern_classifier, ok);
       if (!*ok) return;
       if (IsLexicalVariableMode(parsing_result->descriptor.mode)) {
         ValidateLetPattern(&pattern_classifier, ok);
         if (!*ok) return;
       }
       if (!allow_harmony_destructuring() && !pattern->IsVariableProxy()) {
         ReportUnexpectedToken(next);
         *ok = false;
         return;
       }
+
+      is_for_iteration_variable =
+          var_context == kForStatement &&
+          (peek() == Token::IN || PeekContextualKeyword(CStrVector("of")));
+
+      if (!is_for_iteration_variable &&
+          (pattern->IsObjectLiteral() || pattern->IsArrayLiteral()) &&
+          peek() != Token::ASSIGN) {
+        ReportMessageAt(
+            Scanner::Location(decl_pos, scanner()->location().end_pos),
+            MessageTemplate::kInvalidDestructuringDeclaration);
+        *ok = false;
+        return;
+      }
     }
 
     Scanner::Location variable_loc = scanner()->location();
     const AstRawString* single_name =
         pattern->IsVariableProxy() ? pattern->AsVariableProxy()->raw_name()
                                    : nullptr;
     if (single_name != nullptr) {
       if (fni_ != NULL) fni_->PushVariableName(single_name);
     }
 
     is_for_iteration_variable =
         var_context == kForStatement &&
         (peek() == Token::IN || PeekContextualKeyword(CStrVector("of")));
     if (is_for_iteration_variable &&
         (parsing_result->descriptor.mode == CONST ||
          parsing_result->descriptor.mode == CONST_LEGACY)) {
       parsing_result->descriptor.needs_init = false;
     }
 
     Expression* value = NULL;
     // Harmony consts have non-optional initializers.
     int initializer_position = RelocInfo::kNoPosition;
     if (peek() == Token::ASSIGN || (parsing_result->descriptor.mode == CONST &&

[adamk, 2015/11/03 20:13:53]

This if statement is already set up for handling the required initializer case,
I'd add your code here instead.

[caitp (gmail), 2015/11/03 23:55:31]

Done.

                                     !is_for_iteration_variable)) {
       Expect(Token::ASSIGN, ok);
       if (!*ok) return;
       ExpressionClassifier classifier;
       value = ParseAssignmentExpression(var_context != kForStatement,
                                         &classifier, ok);
       if (!*ok) return;
       ValidateExpression(&classifier, ok);
       if (!*ok) return;
       variable_loc.end_pos = scanner()->location().end_pos;
@@ skipping 3798 matching lines @@
 
 Expression* Parser::SpreadCallNew(Expression* function,
                                   ZoneList<v8::internal::Expression*>* args,
                                   int pos) {
   args->InsertAt(0, function, zone());
 
   return factory()->NewCallRuntime(Context::REFLECT_CONSTRUCT_INDEX, args, pos);
 }
 }  // namespace internal
 }  // namespace v8