Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 1416723008: dart2js cps: Propagate container types for lists. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Propagate container types for lists. Container type masks depend on the allocation site of an object, but the allocation site "key" is an AST node. We need to assign types to nodes in the type propagation pass where the AST nodes are (and should be) inaccessible, so we cannot directly query the type inference from there. The key could be changed to an opaque "AllocationSiteID" object with no members (just a key), but for now, we're just preserving the type mask for container types from build-time. Also has some other type propagation improvements related to containers. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/eb7befc3d925cd7255cd9ac8dca7e9219a1eb1e0

Patch Set 1 #

Patch Set 2 : Clean up a doc comment #

Patch Set 3 : Remove unreachable handling of list constructor in type propagation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -53 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 4 chunks +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 3 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 3 chunks +22 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +14 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 3 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 8 chunks +39 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 2 chunks +5 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 1 month ago (2015-11-05 15:26:13 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 1 month ago (2015-11-06 08:24:07 UTC) #3
asgerf
5 years, 1 month ago (2015-11-06 10:29:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
eb7befc3d925cd7255cd9ac8dca7e9219a1eb1e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698