Chromium Code Reviews
Descriptiondart2js cps: Propagate container types for lists.
Container type masks depend on the allocation site of an object, but the
allocation site "key" is an AST node. We need to assign types to nodes
in the type propagation pass where the AST nodes are (and should be)
inaccessible, so we cannot directly query the type inference from there.
The key could be changed to an opaque "AllocationSiteID" object with no
members (just a key), but for now, we're just preserving the type mask
for container types from build-time.
Also has some other type propagation improvements related to containers.
BUG=
R=kmillikin@google.com
Committed: https://github.com/dart-lang/sdk/commit/eb7befc3d925cd7255cd9ac8dca7e9219a1eb1e0
Patch Set 1 #Patch Set 2 : Clean up a doc comment #Patch Set 3 : Remove unreachable handling of list constructor in type propagation #
Messages
Total messages: 4 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||