Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1416723007: Plugin Power Saver: Remove test that is obsolete. (Closed)

Created:
5 years, 1 month ago by tommycli
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Remove test that is obsolete. This test is obsolete. It's flaky because it should no longer pass. The behavior changed in https://codereview.chromium.org/1421693002/ and I forgot to remove the test. BUG=547224 Committed: https://crrev.com/4517cf34a1884b717d3d7d9de81d40652b219043 Cr-Commit-Position: refs/heads/master@{#356185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 2 chunks +2 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
tommycli
thestig: PTAL
5 years, 1 month ago (2015-10-26 23:15:12 UTC) #3
Lei Zhang
What's the relationship between this and https://codereview.chromium.org/1412963003/ ?
5 years, 1 month ago (2015-10-26 23:16:50 UTC) #4
tommycli
On 2015/10/26 23:16:50, Lei Zhang wrote: > What's the relationship between this and > https://codereview.chromium.org/1412963003/ ...
5 years, 1 month ago (2015-10-26 23:18:10 UTC) #5
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-26 23:22:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416723007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416723007/1
5 years, 1 month ago (2015-10-26 23:26:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 23:49:05 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 23:49:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4517cf34a1884b717d3d7d9de81d40652b219043
Cr-Commit-Position: refs/heads/master@{#356185}

Powered by Google App Engine
This is Rietveld 408576698