Get debugger compiling again

Get debugger compiling again

Recent house cleaning has broken the debugger - mainly around the defunct profiling feature. This makes CL it even more defunct.

Committed: https://skia.googlesource.com/skia/+/87ed6be0e4ea8b0a88915045f697d0fd734ed6f5

[robertphillips, 2015-10-26 13:11:58]

Description was changed from

==========
Get debugger compiling again
==========

to

==========
Get debugger compiling again

Recent house cleaning has broken the debugger - mainly around the defunct
profiling feature. This makes it even more defunct.
==========

[robertphillips, 2015-10-26 13:11:58]

robertphillips@google.com changed reviewers:
+ djsollen@google.com

[robertphillips, 2015-10-26 13:12:04]

Description was changed from

==========
Get debugger compiling again

Recent house cleaning has broken the debugger - mainly around the defunct
profiling feature. This makes it even more defunct.
==========

to

==========
Get debugger compiling again

Recent house cleaning has broken the debugger - mainly around the defunct
profiling feature. This makes CL it even more defunct.
==========

[djsollen, 2015-10-26 13:17:48]

https://codereview.chromium.org/1416723006/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (left):

https://codereview.chromium.org/1416723006/diff/1/debugger/QT/SkDebuggerGUI.c...
debugger/QT/SkDebuggerGUI.cpp:165: void SkDebuggerGUI::actionProfile() {
Can we just remove the profiling option altogether if it doesn't work?  No
reason to have a button in the UI that doesn't do anything.

[robertphillips, 2015-10-26 16:01:07]

https://codereview.chromium.org/1416723006/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (left):

https://codereview.chromium.org/1416723006/diff/1/debugger/QT/SkDebuggerGUI.c...
debugger/QT/SkDebuggerGUI.cpp:165: void SkDebuggerGUI::actionProfile() {
On 2015/10/26 13:17:48, djsollen wrote:
> Can we just remove the profiling option altogether if it doesn't work?  No
> reason to have a button in the UI that doesn't do anything.

Done.

[djsollen, 2015-10-26 16:04:31]

lgtm

[robertphillips, 2015-10-26 16:06:09]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 16:06:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416723006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416723006/40001

[commit-bot: I haz the power, 2015-10-26 16:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 16:17:18]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-26 16:27:28]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-26 16:27:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416723006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416723006/40001

[commit-bot: I haz the power, 2015-10-26 16:28:16]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/87ed6be0e4ea8b0a88915045f697d0fd734ed6f5