Issue 14167007: Don't iterate over a 0 mask resource in RenderPassDrawQuad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14167007: Don't iterate over a 0 mask resource in RenderPassDrawQuad (Closed)

Created:
7 years, 8 months ago by piman

Modified:
7 years, 8 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't iterate over a 0 mask resource in RenderPassDrawQuad A 0 mask resource means we don't use a mask, it's a valid value. Don't iterate over it, because we never want to send 0 to the parent, nor do we want to look up 0 in the child->parent map. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194689

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	cc/quads/draw_quad_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	cc/quads/render_pass_draw_quad.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

I was first thinking to treat this explicitly in DelegatingRenderer/DRLI but I convinced myself that ...

7 years, 8 months ago (2013-04-17 04:47:01 UTC) #1

piman

7 years, 8 months ago (2013-04-17 21:41:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194689 (presubmit successful).

Expand Messages | Collapse Messages