Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1416673009: X87: Remove CallFunctionStub, always call through the Call builtin (also from CallIC). (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove CallFunctionStub, always call through the Call builtin (also from CallIC). port 44c44521ae11859478b42004f57ea93df52526ee (r31823). original commit message: This fixes receiver conversion since the Call builtin does it correctly. BUG= Committed: https://crrev.com/018ecfd16263647d06b6f051f2d4eef9f7e87295 Cr-Commit-Position: refs/heads/master@{#31848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -182 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +8 lines, -159 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-06 02:47:45 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-06 02:52:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416673009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416673009/1
5 years, 1 month ago (2015-11-06 02:52:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 03:10:50 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 03:11:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/018ecfd16263647d06b6f051f2d4eef9f7e87295
Cr-Commit-Position: refs/heads/master@{#31848}

Powered by Google App Engine
This is Rietveld 408576698