Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1416673005: XFA: Fix two minor build errors on Windows (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Fix two minor build errors on Windows - remove unused local variable rtArrow in CFWL_WidgetTP::DrawArrow - remove ~ in class IFX_FontMgr BUG=none R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/59b10dc29ad515e26e96172e7e7d91122cb52a15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M xfa/src/fgas/include/fx_fnt.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/theme/widgettp.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
zhaoqin1
5 years, 2 months ago (2015-10-21 20:08:07 UTC) #1
dsinclair
nit: don't need the diff in the description.
5 years, 2 months ago (2015-10-21 20:09:07 UTC) #3
zhaoqin1
On 2015/10/21 20:09:07, dsinclair wrote: > nit: don't need the diff in the description. hmm, ...
5 years, 2 months ago (2015-10-21 20:10:10 UTC) #4
zhaoqin1
On 2015/10/21 20:10:10, zhaoqin1 wrote: > On 2015/10/21 20:09:07, dsinclair wrote: > > nit: don't ...
5 years, 2 months ago (2015-10-21 20:11:52 UTC) #6
Lei Zhang
lgtm There's a bunch of unused vars, period.
5 years, 2 months ago (2015-10-21 20:41:43 UTC) #7
zhaoqin1
5 years, 2 months ago (2015-10-21 21:57:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59b10dc29ad515e26e96172e7e7d91122cb52a15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698