Increase new content rendering timeout

Increase new content rendering timeout

Due to the Mac graphics bug 537296, when the rendering timeout fires
on Mac it causes graphic artifacts to appear instead of a white screen.
When it occasionally fires simply because the initial rendering of a
page is taking too long, this causes a brief display of the wrong
content before the correct compositor frame arrives.

This CL extends the timeout from 2 seconds to 4, which we hope will prevent
the effects of bug 537296 from manifesting to users, or at least significantly reduce its prevalence, while not
compromising the purpose of the timeout. The display bug will still need to be fixed independently to properly deal with the problem.

BUG=540653
R=creis@chromium.org

Committed: https://crrev.com/00bb4a294d0c4f567dfa60b3222b00a428e63907
Cr-Commit-Position: refs/heads/master@{#354798}

[kenrb, 2015-10-19 16:02:58]

creis: PTAL?

[Charlie Reis, 2015-10-19 16:48:56]

> This CL extends the timeout from 2 seconds to 4, which should prevent the
effects of bug 537296 from manifesting to users while not compromising the
purpose of the timeout.

This isn't really true.  I don't think we have any data to say that all the
cases are less than 4 seconds, and both 2 and 4 seem somewhat arbitrarily
chosen.  Can you rephrase this to say that it just makes the bug less likely
while we investigate an actual fix?

I do think it's very important to fix https://crbug.com/537296, because there
will still be cases that this happens.  (We can consider collecting data on it
if the GPU team needs evidence of the problem, but I imagine it's worth fixing
either way.)

This change LGTM as a stopgap, though.

[kenrb, 2015-10-19 17:10:34]

Description was changed from

==========
Increase new content rendering timeout

Due to the Mac graphics bug 537296, when the rendering timeout fires
on Mac it causes graphic artifacts to appear instead of a white screen.
When it occasionally fires simply because the initial rendering of a
page is taking too long, this causes a brief display of the wrong
content before the correct compositor frame arrives.

This CL extends the timeout from 2 seconds to 4, which should prevent
the effects of bug 537296 from manifesting to users while not
compromising the purpose of the timeout.

BUG=540653
R=creis@chromium.org
==========

to

==========
Increase new content rendering timeout

Due to the Mac graphics bug 537296, when the rendering timeout fires
on Mac it causes graphic artifacts to appear instead of a white screen.
When it occasionally fires simply because the initial rendering of a
page is taking too long, this causes a brief display of the wrong
content before the correct compositor frame arrives.

This CL extends the timeout from 2 seconds to 4, which we hope will prevent
the effects of bug 537296 from manifesting to users, or at least significantly
reduce its prevalence, while not
compromising the purpose of the timeout. The display bug will still need to be
fixed independently to properly deal with the problem.

BUG=540653
R=creis@chromium.org
==========

[kenrb, 2015-10-19 17:10:55]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2015-10-19 17:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416673002/1

[commit-bot: I haz the power, 2015-10-19 17:33:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-19 17:34:27]

Patchset 1 (id:??) landed as
https://crrev.com/00bb4a294d0c4f567dfa60b3222b00a428e63907
Cr-Commit-Position: refs/heads/master@{#354798}