Issue 1416663008: Merge to XFA: Make JS app.setTimeOut() work again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1416663008: Merge to XFA: Make JS app.setTimeOut() work again. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Make JS app.setTimeOut() work again. This regressed in commit 794c9b6. BUG=551248 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1424743006 . (cherry picked from commit 8cadf995e9a0fec8da19f69edac9d10fccca7eed) (cherry picked from commit 955930dce7e4b5c764cdd34b134baea4207de523) Committed: https://pdfium.googlesource.com/pdfium/+/79e893a1d0f2083f17c40ccadf2cc1250aad5a14

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -111 lines)			Patch
M	fpdfsdk/src/fpdfformfill_embeddertest.cpp	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Object.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	testing/embedder_test_timer_handling_delegate.h	View	2 chunks	+30 lines, -0 lines	0 comments	Download
A +	testing/resources/bug_551248.in	View	2 chunks	+1 line, -43 lines	0 comments	Download
A +	testing/resources/bug_551248.pdf	View	3 chunks	+9 lines, -55 lines	0 comments	Download
M	testing/test_support.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	testing/test_support.cpp	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-05 00:02:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
79e893a1d0f2083f17c40ccadf2cc1250aad5a14 (presubmit successful).