Enable pp::flash::FontFile support on Windows

chrome/renderer/pepper/pepper_flash_font_file_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/pepper/pepper_flash_font_file_host.h"
 
+#include "base/sys_byteorder.h"
 #include "build/build_config.h"
 #include "content/public/renderer/renderer_ppapi_host.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/host/host_message_context.h"
 #include "ppapi/host/ppapi_host.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/serialized_structs.h"
 
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
 #include "content/public/common/child_process_sandbox_support_linux.h"
+#elif defined(OS_WIN)
+#include "third_party/skia/include/ports/SkFontMgr.h"
 #endif
 
 PepperFlashFontFileHost::PepperFlashFontFileHost(
     content::RendererPpapiHost* host,
     PP_Instance instance,
     PP_Resource resource,
     const ppapi::proxy::SerializedFontDescription& description,
     PP_PrivateFontCharset charset)
     : ResourceHost(host->GetPpapiHost(), instance, resource) {
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
   fd_.reset(content::MatchFontWithFallback(
       description.face,
       description.weight >= PP_BROWSERFONT_TRUSTED_WEIGHT_BOLD,
       description.italic,
       charset,
       PP_BROWSERFONT_TRUSTED_FAMILY_DEFAULT));
+#elif defined(OS_WIN)
+  int weight = description.weight;
+  if (weight == FW_DONTCARE)
+    weight = SkFontStyle::kNormal_Weight;
+  SkFontStyle style(weight, SkFontStyle::kNormal_Width,
+                    description.italic ? SkFontStyle::kItalic_Slant
+                                       : SkFontStyle::kUpright_Slant);
+  skia::RefPtr<SkFontMgr> font_mgr = skia::AdoptRef(SkFontMgr::RefDefault());
+  typeface_ = skia::AdoptRef(
+      font_mgr->matchFamilyStyle(description.face.c_str(), style));
 #endif  // defined(OS_LINUX) || defined(OS_OPENBSD)
 }
 
 PepperFlashFontFileHost::~PepperFlashFontFileHost() {}
 
 int32_t PepperFlashFontFileHost::OnResourceMessageReceived(
     const IPC::Message& msg,
     ppapi::host::HostMessageContext* context) {
   PPAPI_BEGIN_MESSAGE_MAP(PepperFlashFontFileHost, msg)
     PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_FlashFontFile_GetFontTable,
                                       OnGetFontTable)
   PPAPI_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
+bool PepperFlashFontFileHost::GetFontData(uint32_t table,
+                                          void* buffer,
+                                          size_t* length) {
+  bool result = false;
+#if defined(OS_LINUX) || defined(OS_OPENBSD)
+  int fd = fd_.get();
+  if (fd != -1)
+    result = content::GetFontTable(fd, table, 0 /* offset */,

[Xing, 2015/10/23 21:59:02]

Fixed the typo of extra ')', and did the necessary type conversion to avoid
compiler error on Linux

+                 reinterpret_cast<uint8_t*>(buffer), length);
+#elif defined(OS_WIN)
+  if (typeface_) {
+    table = base::ByteSwap(table);
+    if (buffer == NULL) {

[bbudge, 2015/10/28 00:06:33]

Digging into skia a little bit, it seems like you're duplicating the logic in
SkTypeface::getTableData, which just returns the length if buffer == nullptr.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

Could you simplify the code here to just call getTableData?

Also, I'm a little confused because getTableData also potentially byte swaps the
tag (again).

[Xing, 2015/10/28 21:52:50]

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...
It calls into |DWriteFontTypeface::onGetTableData()|, not
|LogFontTypeface::onGetTableData()|, so the logic does not seem to be quite
duplicate.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

table tag is of type SkFontTableTag which is defined as:

/** Machine endian. */
typedef uint32_t SkFontTableTag;

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/i...

Flash already has the table tag in big endian, so the swap here is just another
format change for skia's interface.

[bbudge, 2015/11/02 20:20:17]

OK.

+      *length = typeface_->getTableSize(table);
+      if (*length > 0)
+        result = true;
+    } else {
+      size_t new_length = typeface_->getTableData(table, 0, *length, buffer);
+      if (new_length == *length)
+        result = true;
+    }
+  }
+#endif
+  return result;
+}
+
 int32_t PepperFlashFontFileHost::OnGetFontTable(
     ppapi::host::HostMessageContext* context,
     uint32_t table) {
   std::string contents;
   int32_t result = PP_ERROR_FAILED;
-#if defined(OS_LINUX) || defined(OS_OPENBSD)
-  int fd = fd_.get();
-  if (fd != -1) {
-    size_t length = 0;
-    if (content::GetFontTable(fd, table, 0 /* offset */, NULL, &length)) {
-      contents.resize(length);
-      uint8_t* contents_ptr =
-          reinterpret_cast<uint8_t*>(const_cast<char*>(contents.c_str()));
-      if (content::GetFontTable(
-              fd, table, 0 /* offset */, contents_ptr, &length)) {
-        result = PP_OK;
-      } else {
-        contents.clear();
-      }
+  size_t length = 0;
+  if (GetFontData(table, NULL, &length)) {
+    contents.resize(length);
+    uint8_t* contents_ptr =
+        reinterpret_cast<uint8_t*>(const_cast<char*>(contents.c_str()));
+    if (GetFontData(table, contents_ptr, &length)) {
+      result = PP_OK;
+    } else {
+      contents.clear();
     }
   }
-#endif  // defined(OS_LINUX) || defined(OS_OPENBSD)
-
   context->reply_msg = PpapiPluginMsg_FlashFontFile_GetFontTableReply(contents);
   return result;
 }