Chromium Code Reviews| Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
| diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
| index 4d49541881380ea1c0fa0f93dafff75d77ce1808..d57ab24129ee58054df68286a5a9bba3ffc1d6f1 100644 |
| --- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
| +++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
| @@ -332,7 +332,7 @@ TEST_F(ManagePasswordsUIControllerTest, SlowNavigations) { |
| controller()->OnPasswordSubmitted(test_form_manager.Pass()); |
| ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_STATE); |
| - // Fake-navigate after a second. We expect the bubble's state to be reset |
| + // Fake-navigate after 5 seconds. We expect the bubble's state to be reset |
| // if a navigation occurs after this limit. |
| controller()->SetElapsed( |
| base::TimeDelta::FromMilliseconds(kSlowNavigationDelayInMS)); |
| @@ -571,3 +571,19 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordUpdated) { |
| controller()->UpdatePassword(autofill::PasswordForm()); |
| ExpectIconStateIs(password_manager::ui::MANAGE_STATE); |
| } |
| + |
| +TEST_F(ManagePasswordsUIControllerTest, NavigationWhenUpdateBubbleActive) { |
| + scoped_ptr<password_manager::PasswordFormManager> test_form_manager( |
| + CreateFormManager()); |
| + controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass()); |
| + EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE, |
| + controller()->state()); |
| + // Fake-navigate after 5 seconds. We expect the bubble's state to be reset |
| + // if a navigation occurs after this limit. |
| + controller()->SetElapsed( |
| + base::TimeDelta::FromMilliseconds(kSlowNavigationDelayInMS)); |
| + controller()->DidNavigateMainFrame(content::LoadCommittedDetails(), |
| + content::FrameNavigateParams()); |
|
vasilii
2015/11/04 16:12:52
Check that the state is 'inactive'.
dvadym
2015/11/04 16:20:23
Done.
|
| + // The following line shouldn't crash browser. |
| + controller()->OnNoInteractionOnUpdate(); |
| +} |