Separate tracking for profiles that haven't been accessed in 4 weeks.

Separate tracking for profiles that haven't been accessed in 4 weeks.

This won't be committed until M35 because last-used-time wasn't recorded until M34 with all profiles starting as "unused" at that time.

BUG=295817
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253242

[bcwhite, 2014-01-17 19:00:46]

Since this affects recorded metrics, I'd like all OWNERS to take a look.

[bcwhite, 2014-01-22 19:28:14]

Ping?

[Elliot Glaysher, 2014-01-22 21:15:21]

Removing myself and explicitly pointing this towards rlp, who appears to have
actually worked with this file in the past (and hopefully has relevant things to
say.)

[rpetterson, 2014-01-22 21:40:27]

https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.cc (right):

https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.cc:69: if
(info_cache.GetProfileActiveTimeAtIndex(i) < oldest) {
Overall I think this is an interesting metric to record. My only question is
whether you want to not record the other metrics if it is unused. Would it
better to know that I've got 10 managed profiles, 9 signed in profiles and 3 of
those unused? Would we want to know if the unused profiles were also managed
and/or signed in?

[bcwhite, 2014-01-23 14:07:38]

https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.cc (right):

https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.cc:69: if
(info_cache.GetProfileActiveTimeAtIndex(i) < oldest) {
From the point-of-view of "signed in" tracking, we wanted to be able to discount
profiles that were created and never used, as frequently happens when people are
experimenting.

I think if we wanted the detail you mention, we'd have to duplicate all the
stats: managed, managed_unused, signedin, signedin_unused, total, total_unused. 
Otherwise, when looking at stats you'd have no idea if it was the signed-in &
managed profiles that were unused or the opposite.

[rpetterson, 2014-01-23 19:28:52]

On 2014/01/23 14:07:38, bcwhite wrote:
>
https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
> File chrome/browser/profiles/profile_metrics.cc (right):
> 
>
https://codereview.chromium.org/141663004/diff/1/chrome/browser/profiles/prof...
> chrome/browser/profiles/profile_metrics.cc:69: if
> (info_cache.GetProfileActiveTimeAtIndex(i) < oldest) {
> From the point-of-view of "signed in" tracking, we wanted to be able to
discount
> profiles that were created and never used, as frequently happens when people
are
> experimenting.
> 
> I think if we wanted the detail you mention, we'd have to duplicate all the
> stats: managed, managed_unused, signedin, signedin_unused, total,
total_unused. 
> Otherwise, when looking at stats you'd have no idea if it was the signed-in &
> managed profiles that were unused or the opposite.

Fair enough. LGTM. Looking forward to seeing this data!

[bcwhite, 2014-02-24 17:49:08]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-02-24 17:49:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/141663004/1

[commit-bot: I haz the power, 2014-02-24 18:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-24 18:44:40]

Retried try job too often on win_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bcwhite, 2014-02-25 18:51:24]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2014-02-25 18:52:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/141663004/1

[commit-bot: I haz the power, 2014-02-25 20:18:32]

Change committed as 253242