Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1416623004: XFA: make JS_Define.h match master (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: make JS_Define.h match master Remove parameter names in template specialization. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3bfe9afdf145a28210f8a9ed893dffe2df508f9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M fpdfsdk/src/javascript/JS_Define.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, trivial review. Opposite side of previous CL.
5 years, 1 month ago (2015-11-04 20:40:44 UTC) #3
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-04 21:51:01 UTC) #4
Tom Sepez
5 years, 1 month ago (2015-11-04 22:17:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bfe9afdf145a28210f8a9ed893dffe2df508f9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698