Issue 1416603010: win: Add DumpAndCrash to client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1416603010: win: Add DumpAndCrash to client (Closed)

Created:
5 years, 1 month ago by scottmg

Modified:
5 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Add DumpAndCrash to client Something like this is required to implement something like https://code.google.com/p/chromium/codesearch#chromium/src/components/crash/content/app/breakpad_win.cc&l=397 in Chrome (used by Syzygy and V8 in x64 it looks like). I didn't want to expose UnhandledExceptionFilter() directly as it's __stdcall so adding a forwarder to CrashpadClient seemed tidier, but the functionality matches what is needed. R=mark@chromium.org BUG=chromium:546288 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9e4cd8f07b107edf9cbba5c5760967d5aeb8e2bd

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	client/crashpad_client.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	client/crashpad_client_win.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Mentovai

LGTM, but I think that some of what breakpad_win.cc is doing (like the NtTerminateProcess wrapper) ...

5 years, 1 month ago (2015-11-06 21:53:42 UTC) #2

scottmg

On 2015/11/06 21:53:42, Mark Mentovai wrote: > LGTM, but I think that some of what ...

5 years, 1 month ago (2015-11-06 22:07:23 UTC) #3

scottmg

5 years, 1 month ago (2015-11-06 22:08:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e4cd8f07b107edf9cbba5c5760967d5aeb8e2bd (presubmit successful).