Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 1416603008: Tweaks for the status page. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/status/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart
index 24fbb2a3cada18c1186ee3cff5791d54a0717379..94dd6f995164ed51df9fd61244635b876fc0df81 100644
--- a/pkg/analysis_server/lib/src/status/get_handler.dart
+++ b/pkg/analysis_server/lib/src/status/get_handler.dart
@@ -1554,6 +1554,12 @@ class GetHandler {
}
}
+ void _writeListItem(StringBuffer buffer, writer()) {
+ buffer.write('<li>');
+ writer();
+ buffer.write('</li>');
+ }
+
void _writeListOfStrings(
StringBuffer buffer, String listName, Iterable<String> items) {
List<String> itemList = items.toList();
@@ -1562,12 +1568,12 @@ class GetHandler {
b = b.toLowerCase();
return a.compareTo(b);
});
- buffer.write('List "listName" containing ${itemList.length} entries:');
+ buffer.write('List "$listName" containing ${itemList.length} entries:');
buffer.write('<ul>');
for (String member in itemList) {
- buffer.write('<li>');
- buffer.write(member);
- buffer.write('</li>');
+ _writeListItem(buffer, () {
+ buffer.write(member);
+ });
}
buffer.write('</ul>');
}
@@ -1928,9 +1934,9 @@ class GetHandler {
buffer.write('List containing ${value.length} entries');
buffer.write('<ul>');
for (var entry in value) {
- buffer.write('<li>');
- _writeValueAsHtml(buffer, entry, linkParameters);
- buffer.write('</li>');
+ _writeListItem(buffer, () {
+ _writeValueAsHtml(buffer, entry, linkParameters);
+ });
}
buffer.write('</ul>');
} else if (value is AstNode) {
@@ -1943,19 +1949,24 @@ class GetHandler {
buffer.write('<i>$link</i>');
} else if (value is UsedLocalElements) {
buffer.write('<ul>');
- {
+ _writeListItem(buffer, () {
HashSet<Element> elements = value.elements;
buffer.write('List "elements" containing ${elements.length} entries');
buffer.write('<ul>');
for (Element element in elements) {
- buffer.write('<li>');
- buffer.write('<i>${element.runtimeType}</i> $element');
- buffer.write('</li>');
+ _writeListItem(buffer, () {
+ String elementStr = HTML_ESCAPE.convert(element.toString());
+ buffer.write('<i>${element.runtimeType}</i> $elementStr');
+ });
}
buffer.write('</ul>');
- }
- _writeListOfStrings(buffer, 'members', value.members);
- _writeListOfStrings(buffer, 'readMembers', value.readMembers);
+ });
+ _writeListItem(buffer, () {
+ _writeListOfStrings(buffer, 'members', value.members);
+ });
+ _writeListItem(buffer, () {
+ _writeListOfStrings(buffer, 'readMembers', value.readMembers);
+ });
buffer.write('</ul>');
} else {
buffer.write(HTML_ESCAPE.convert(value.toString()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698