Issue 1416603002: VM: Always inline typed data list factories, clean up inliner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1416603002: VM: Always inline typed data list factories, clean up inliner. (Closed)

Created:
5 years, 2 months ago by Florian Schneider

Modified:
5 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: Always inline typed data list factories, clean up inliner. They just redirect to the native typed data list constructor. Inlining them makes type propagation more precise. There is no size cost with always inlining these since they just contain a constructor call. Also, remove dead code from the inliner: Unoptimized code is not accessed during optimized compilation anymore. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/33eed24b5704a4ef1eb24311e27e1eb1eda45e4f

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
	M	runtime/vm/method_recognizer.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 2 months ago (2015-10-19 16:03:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
33eed24b5704a4ef1eb24311e27e1eb1eda45e4f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages