Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 14166003: Move all generic Chromium expected results to the generic location (Closed)

Created:
7 years, 8 months ago by Steve Block
Modified:
7 years, 8 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Move all generic Chromium expected results to the generic location This means that there are no longer any expected results in LayoutTests/platform/chromium/..., so this location is removed from the fallback path. Also updates an inspector tool and a rebaseline unit test. BUG=229807 R=abarth,pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M LayoutTests/http/tests/inspector/resources/test-scanner.html View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py View 2 chunks +5 lines, -5 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py View 1 chunk +0 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py View 1 chunk +0 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
This depends on https://codereview.chromium.org/14146002 Adding pfeldman for change to inspector tool. How can I run ...
7 years, 8 months ago (2013-04-11 09:57:08 UTC) #1
Steve Block
I haven't included the 7000 file moves in the upload. I'll add those when I ...
7 years, 8 months ago (2013-04-11 10:04:37 UTC) #2
pfeldman
devtools lgtm
7 years, 8 months ago (2013-04-11 11:49:33 UTC) #3
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-11 16:49:14 UTC) #4
Steve Block
7 years, 8 months ago (2013-04-12 03:34:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r148246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698