Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: net/quic/crypto/proof_test.cc

Issue 1416583005: Add support of serving SCT on the server side in QUIC, gated by QUIC_VERSION_30. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106687764
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/proof_source_chromium_openssl.cc ('k') | net/quic/crypto/quic_crypto_server_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_test.cc
diff --git a/net/quic/crypto/proof_test.cc b/net/quic/crypto/proof_test.cc
index b493f225fd669afa730865f0d4546e945647eaf5..67055be07fd45f60d6bfae684829a5d07b138e14 100644
--- a/net/quic/crypto/proof_test.cc
+++ b/net/quic/crypto/proof_test.cc
@@ -118,18 +118,20 @@ TEST(ProofTest, DISABLED_Verify) {
const string hostname = "test.example.com";
const vector<string>* certs;
const vector<string>* first_certs;
- string error_details, signature, first_signature;
+ string error_details, signature, first_signature, first_cert_sct, cert_sct;
IPAddressNumber server_ip;
ASSERT_TRUE(source->GetProof(server_ip, hostname, server_config,
false /* no ECDSA */, &first_certs,
- &first_signature));
+ &first_signature, &first_cert_sct));
ASSERT_TRUE(source->GetProof(server_ip, hostname, server_config,
- false /* no ECDSA */, &certs, &signature));
+ false /* no ECDSA */, &certs, &signature,
+ &cert_sct));
// Check that the proof source is caching correctly:
ASSERT_EQ(first_certs, certs);
ASSERT_EQ(signature, first_signature);
+ ASSERT_EQ(first_cert_sct, cert_sct);
RunVerification(
verifier.get(), hostname, server_config, *certs, signature, true);
« no previous file with comments | « net/quic/crypto/proof_source_chromium_openssl.cc ('k') | net/quic/crypto/quic_crypto_server_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698