tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py - Issue 1416533003: Handle corrupted data in Telemetry WebRtcRendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

Issue 1416533003: Handle corrupted data in Telemetry WebRtcRendering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more checks to testCorruptData test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

index ef7f8b265d5a4fc00e8f21e75d59bd77a24b55de..b49563e6caa1bf31d02028ec4235c85e6088f28b 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py

@@ -47,6 +47,10 @@ class WebRtcRenderingTimelineMetric(timeline_based_metric.TimelineBasedMetric):

# Create a TimeStats object whose members have None values.

rendering_stats = stats_helper.TimeStats()

none_reason = 'No WebMediaPlayerMS::UpdateCurrentFrame event found'

+ elif rendering_stats.invalid_data:

+ # Throw away the data.

+ rendering_stats = stats_helper.TimeStats()

+ none_reason = 'WebMediaPlayerMS data is corrupted.'

results.AddValue(list_of_scalar_values.ListOfScalarValues(

results.current_page,

'WebRTCRendering_drift_time',

« no previous file with comments | « tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats_unittest.py ('k') | no next file » | no next file with comments »