Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py

Issue 1416533003: Handle corrupted data in Telemetry WebRtcRendering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more checks to testCorruptData test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py
index 30be6c82e5d3d5e33ac8abe38361ed117dba3088..55c72d0f46caa39d88a5433ad9508c820100731d 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py
@@ -37,6 +37,7 @@ class TimeStats(object):
self.rendering_length_error = rendering_length_error
self.fps = fps
self.frame_distribution = frame_distribution
+ self.invalid_data = False
@@ -335,6 +336,11 @@ class WebMediaPlayerMsRenderingStats(object):
continue
cadence = self._GetCadence(relevant_events)
+ if not cadence:
+ stats = TimeStats()
+ stats.invalid_data = True
+ return stats
+
frame_distribution = self._GetSourceToOutputDistribution(cadence)
fps = self._GetFpsFromCadence(frame_distribution)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698