Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 141653020: Move OAuth2 client id and secret switches to gaia_switches.h (Closed)

Created:
6 years, 10 months ago by msarda
Modified:
6 years, 10 months ago
CC:
chromium-reviews, blundell
Visibility:
Public.

Description

Move OAuth2 client id and secret switches to gaia_switches.h The OAuth2 client id and secret switches are also used on Chrome for iOS downstream so they need to be available in a public header. BUG=285944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250419

Patch Set 1 #

Patch Set 2 : Attempt to fix google_api_keys_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M google_apis/gaia/gaia_switches.h View 1 chunk +6 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/google_api_keys.cc View 2 chunks +1 line, -10 lines 0 comments Download
M google_apis/google_api_keys_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msarda
Please take a look.
6 years, 10 months ago (2014-02-11 09:56:40 UTC) #1
Roger Tawa OOO till Jul 10th
Lgtm Is the header needed in the unit tests?
6 years, 10 months ago (2014-02-11 13:56:32 UTC) #2
msarda
On 2014/02/11 13:56:32, Roger Tawa wrote: > Lgtm > > Is the header needed in ...
6 years, 10 months ago (2014-02-11 14:07:13 UTC) #3
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 10 months ago (2014-02-11 14:07:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/141653020/70001
6 years, 10 months ago (2014-02-11 14:08:43 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 15:56:36 UTC) #6
Message was sent while issue was closed.
Change committed as 250419

Powered by Google App Engine
This is Rietveld 408576698