Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 141653017: Use SkFontMgr for synthetic font styles on windows (Closed)

Created:
6 years, 11 months ago by eae
Modified:
6 years, 11 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Use SkFontMgr for synthetic font styles on windows Change FontCustomPlatformData::fontPlatformData to use the SkFontMgr API on Windows for synthetic bold and italic. Without it we'd fall back on GDI even if DirectWrite is enabled. BUG=25541 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
6 years, 11 months ago (2014-01-22 21:32:31 UTC) #1
dglazkov
lgtm
6 years, 11 months ago (2014-01-22 21:44:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/141653017/1
6 years, 11 months ago (2014-01-22 21:45:41 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 01:52:25 UTC) #4
Message was sent while issue was closed.
Change committed as 165591

Powered by Google App Engine
This is Rietveld 408576698