Issue 141653016: Remove Heap::MaxRegularSpaceAllocationSize and use Page::MaxRegularHeapObjectSize instead.

Issue 141653016: Remove Heap::MaxRegularSpaceAllocationSize and use Page::MaxRegularHeapObjectSize instead. (Closed)

Created:
6 years, 11 months ago by Hannes Payer (out of office)

Modified:
6 years, 11 months ago

Reviewers:
mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove Heap::MaxRegularSpaceAllocationSize and use Page::MaxRegularHeapObjectSize instead. BUG= R=mstarzinger@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18776

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -47 lines)			Patch
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/heap.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-visiting.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View		6 chunks	+12 lines, -12 lines	0 comments	Download
M	src/spaces-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-alloc.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-spaces.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/allocation-folding.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-3027.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/141653016/diff/1/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/141653016/diff/1/src/spaces.h#newcode782 src/spaces.h:782: // Object area size in bytes ...

6 years, 11 months ago (2014-01-22 16:04:50 UTC) #2

Hannes Payer (out of office)

Committed patchset #2 manually as r18776 (presubmit successful).

6 years, 11 months ago (2014-01-23 13:02:44 UTC) #4

Hannes Payer (out of office)

6 years, 11 months ago (2014-01-27 14:35:20 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/141653016/diff/1/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/141653016/diff/1/src/spaces.h#newcode782
src/spaces.h:782: // Object area size in bytes of non code objects.
On 2014/01/22 16:04:51, Michael Starzinger wrote:
> nit: s/non code objects/non-code pages/ (or "non-code spaces").

Done. Got garbage collected.

https://codereview.chromium.org/141653016/diff/1/test/mjsunit/allocation-fold...
File test/mjsunit/allocation-folding.js (right):

https://codereview.chromium.org/141653016/diff/1/test/mjsunit/allocation-fold...
test/mjsunit/allocation-folding.js:104: // Test to exceed the
Page::MaxRegularHeapObjectSize limit.
On 2014/01/22 16:04:51, Michael Starzinger wrote:
> nit: s/exceed/almost exceed/

Done.

Expand Messages | Collapse Messages