Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 141653008: Add infrastructure for skipping tests in GC stress mode. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add infrastructure for skipping tests in GC stress mode. Also move the GC stress configuration from the buildbot to the test runner. BUG= R=jkummerow@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18708

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -58 lines) Patch
M test/mjsunit/allocation-site-info.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/array-literal-feedback.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/d8-performance-now.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/elements-kind.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +16 lines, -6 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-165637.js View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/run-deopt-fuzzer.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/run-tests.py View 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL, Jakob at the test runner and Michael at the skipped tests...
6 years, 11 months ago (2014-01-21 11:30:53 UTC) #1
mvstanton
lgtm, one small nit. https://codereview.chromium.org/141653008/diff/1/test/mjsunit/elements-kind.js File test/mjsunit/elements-kind.js (left): https://codereview.chromium.org/141653008/diff/1/test/mjsunit/elements-kind.js#oldcode29 test/mjsunit/elements-kind.js:29: // Flags: --nostress-opt --nostress-compaction --gc-interval=-1 ...
6 years, 11 months ago (2014-01-21 11:58:34 UTC) #2
Michael Achenbach
https://codereview.chromium.org/141653008/diff/1/test/mjsunit/elements-kind.js File test/mjsunit/elements-kind.js (left): https://codereview.chromium.org/141653008/diff/1/test/mjsunit/elements-kind.js#oldcode29 test/mjsunit/elements-kind.js:29: // Flags: --nostress-opt --nostress-compaction --gc-interval=-1 On 2014/01/21 11:58:35, mvstanton ...
6 years, 11 months ago (2014-01-21 12:10:29 UTC) #3
Jakob Kummerow
Yay! Having --gc-stress as a flag for run-tests.py is a most welcome improvement for local ...
6 years, 11 months ago (2014-01-21 12:29:56 UTC) #4
Michael Achenbach
6 years, 11 months ago (2014-01-21 12:41:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18708 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698