chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java - Issue 14165005: Remaining issues with making the autofill dialog usable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

Issue 14165005: Remaining issues with making the autofill dialog usable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unused adapter class Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

index 1ede21677244cae7018fd55758f95787f65526d3..7c307471c918b585d15b6bc50b412d7dbeab294b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogUtils.java

@@ -86,7 +86,7 @@ public class AutofillDialogUtils {

case AutofillDialogConstants.SECTION_BILLING :

return R.id.editing_layout_billing;

case AutofillDialogConstants.SECTION_EMAIL :

- return INVALID_ID;

+ return R.id.editing_layout_email;

default:

assert(false);

return INVALID_ID;

@@ -127,7 +127,8 @@ public class AutofillDialogUtils {

public static int getViewIDForField(int section, int field) {

switch (section) {

case AutofillDialogConstants.SECTION_EMAIL :

- return 0;

+ assert(field == AutofillDialogConstants.EMAIL_ADDRESS);

+ return R.id.email_address;

case AutofillDialogConstants.SECTION_CC :

switch (field) {

case AutofillDialogConstants.CREDIT_CARD_NUMBER :