Issue 14165004: Move creation of collection prototypes into JavaScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14165004: Move creation of collection prototypes into JavaScript. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger

Modified:
7 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move creation of collection prototypes into JavaScript. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14234

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -14 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+9 lines, -13 lines	0 comments	Download
M	src/collection.js	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/collections.js	View	2 chunks	+19 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with comment https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js#newcode257 test/mjsunit/harmony/collections.js:257: // Test type of the Set, ...

7 years, 8 months ago (2013-04-11 13:15:14 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js#newcode257 test/mjsunit/harmony/collections.js:257: // Test type of the Set, ...

7 years, 8 months ago (2013-04-11 13:31:28 UTC) #3

Michael Starzinger

7 years, 8 months ago (2013-04-11 13:32:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14234 (presubmit successful).

Expand Messages | Collapse Messages