Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1416493007: [turbofan] Implement the implicit ToObject for property access. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement the implicit ToObject for property access. Drive-by-fix: Move IC::GetRootConstructor to Map::GetConstructorFunction, so we can use that in the ICs, Crankshaft and Turbofan. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/44f4c1d66a1476f2a2f6101616525a32f113eef3 Cr-Commit-Position: refs/heads/master@{#31577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +20 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic-inl.h View 3 chunks +6 lines, -19 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-26 14:57:56 UTC) #1
Benedikt Meurer
Hey Jaro, Does the automagic ToObject in GetV, somewhat unified with the ICs and Crankshaft. ...
5 years, 1 month ago (2015-10-26 14:59:14 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-10-26 15:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416493007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416493007/1
5 years, 1 month ago (2015-10-26 15:33:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 15:55:42 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:55:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44f4c1d66a1476f2a2f6101616525a32f113eef3
Cr-Commit-Position: refs/heads/master@{#31577}

Powered by Google App Engine
This is Rietveld 408576698