Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1416453005: Adds window resizing (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds window resizing I need to constrain sizes more, but this is a good start. Also, it looks like resizing doesn't actually work. I suspect that is a bug in NativeWidgetMus (or WindowTreeHostMojo). Will figure that out separately. This adds the new test suite, but no bots are running it yet. I'll update the build files separately. BUG=548420 TEST=none R=ben@chromium.org Committed: https://crrev.com/b6cb43b07ff48ffdd0467e12ce7e0256b822cace Cr-Commit-Position: refs/heads/master@{#357000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -18 lines) Patch
M components/mus/example/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M components/mus/example/wm/BUILD.gn View 3 chunks +38 lines, -2 lines 0 comments Download
M components/mus/example/wm/move_loop.h View 4 chunks +37 lines, -1 line 0 comments Download
M components/mus/example/wm/move_loop.cc View 4 chunks +81 lines, -4 lines 0 comments Download
A components/mus/example/wm/move_loop_unittest.cc View 1 chunk +180 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
A components/mus/public/cpp/tests/test_window.h View 1 chunk +26 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_unittest.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 1 month ago (2015-10-29 23:54:39 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-10-29 23:58:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416453005/1
5 years, 1 month ago (2015-10-30 00:04:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 00:43:34 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:44:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6cb43b07ff48ffdd0467e12ce7e0256b822cace
Cr-Commit-Position: refs/heads/master@{#357000}

Powered by Google App Engine
This is Rietveld 408576698