Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Issue 1416453004: Re-enable accessor-map-sharing test (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-enable accessor-map-sharing test It doesn't fail on tip of tree, we'll investigate if it recurs. R=mstarzinger@chromium.org BUG=v8:4493 LOG=N Committed: https://crrev.com/21724d6799c846d02d3038b49624c83f857d8188 Cr-Commit-Position: refs/heads/master@{#31489}

Patch Set 1 #

Patch Set 2 : removed test from status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Michael, I couldn't reproduce the gcstress failure so I'm re-enabling accessor-map-sharing...
5 years, 2 months ago (2015-10-22 14:16:18 UTC) #2
Michael Starzinger
LGTM, fine with me, let's see what the waterfall has to say. Thanks!
5 years, 2 months ago (2015-10-22 14:39:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416453004/20001
5 years, 2 months ago (2015-10-23 05:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-23 06:14:09 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 06:14:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21724d6799c846d02d3038b49624c83f857d8188
Cr-Commit-Position: refs/heads/master@{#31489}

Powered by Google App Engine
This is Rietveld 408576698