Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1416373005: [Swarming] Let test runner exit gracefully after test failures. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Let test runner exit gracefully after test failures. The flake detection is done on the infra-side according to the contents of the json test results. We don't want the runner to fail after flakes. This was controlled on the infra side by accepting any exit codes so far. After the swarming switch, this is more difficult, because the runner is wrapped by the swarming collect script. There, failing exit codes can mean many things, including network failures. Therefore, we now force exit code 0 with test failures if those failures are reported in the formal test results json. The infrastructure will take care of reporting the flakes and failures accordingly. BUG=chromium:535160 LOG=n Committed: https://crrev.com/efcc7fb2bd88393450ca03e5a427fd8dc4e09f1d Cr-Commit-Position: refs/heads/master@{#31740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/run-tests.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Michael Achenbach
PTAL
5 years, 1 month ago (2015-11-03 10:07:20 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416373005/1
5 years, 1 month ago (2015-11-03 10:08:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 10:24:36 UTC) #7
tandrii_google
lgtm from chrome-infra perspective
5 years, 1 month ago (2015-11-03 10:31:34 UTC) #9
Jakob Kummerow
lgtm
5 years, 1 month ago (2015-11-03 10:38:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416373005/1
5 years, 1 month ago (2015-11-03 10:53:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 10:55:10 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 10:55:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efcc7fb2bd88393450ca03e5a427fd8dc4e09f1d
Cr-Commit-Position: refs/heads/master@{#31740}

Powered by Google App Engine
This is Rietveld 408576698