Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 141633005: Revert of If the destination directory doesn't contain the desired repo, delete it (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, reed1
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert of If the destination directory doesn't contain the desired repo, delete it (https://codereview.chromium.org/61623008/) Reason for revert: This breaks `gclient sync` for me. Before this patch: ________ found .git directory; skipping src After this patch: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. Original issue's description: > If the destination directory doesn't contain the desired repo, delete it > > Basic functionality - this may not be in quite the right place. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245404 TBR=iannucci@chromium.org,ilevy@chromium.org,cmp@chromium.org,maruel@chromium.org,morrita@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -184 lines) Patch
M gclient.py View 2 chunks +0 lines, -34 lines 0 comments Download
M gclient_scm.py View 8 chunks +109 lines, -15 lines 0 comments Download
M tests/gclient_scm_test.py View 15 chunks +48 lines, -56 lines 0 comments Download
M tests/gclient_smoketest.py View 5 chunks +3 lines, -79 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of If the destination directory doesn't contain the desired repo, delete it
6 years, 11 months ago (2014-01-17 16:55:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/141633005/1
6 years, 11 months ago (2014-01-17 16:55:18 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 16:57:11 UTC) #3
Message was sent while issue was closed.
Change committed as 245530

Powered by Google App Engine
This is Rietveld 408576698