Issue 141633003: Activate calling push-to-trunk in auto-roll script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141633003: Activate calling push-to-trunk in auto-roll script. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach

Modified:
6 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Activate calling push-to-trunk in auto-roll script. - Call push-to-trunk through python not through the shell - Restore tree state on script errors - Mock out python call in unit tests - The actual call stays behind a flag BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18664

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -4 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View	4 chunks	+19 lines, -4 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 11 months ago (2014-01-17 11:29:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18664 (presubmit successful).

Expand Messages | Collapse Messages