arc-bridge: Start ArcBridgeService on session start

chrome/browser/ui/startup/startup_browser_creator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "apps/app_restore_service.h"
@@ skipping 95 matching lines @@
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #include "chrome/browser/apps/app_launch_for_metro_restart_win.h"
 #endif
 
 #if defined(ENABLE_RLZ)
 #include "components/rlz/rlz_tracker.h"
 #endif
 
+#if defined(OS_CHROMEOS)
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_prefs.h"
+#endif
+
 using content::ChildProcessSecurityPolicy;
 using content::WebContents;
 using extensions::Extension;
 
 namespace {
 
 // Utility functions ----------------------------------------------------------
 
 enum LaunchMode {
   LM_TO_BE_DECIDED = 0,       // Possibly direct launch or via a shortcut.
@@ skipping 460 matching lines @@
     VLOG(1) << "Pref: default";
 
   apps::AppRestoreService* restore_service =
       apps::AppRestoreServiceFactory::GetForProfile(profile_);
   // NULL in incognito mode.
   if (restore_service) {
     restore_service->HandleStartup(apps::AppRestoreService::ShouldRestoreApps(
         StartupBrowserCreator::WasRestarted()));
   }
 
+#if defined(OS_CHROMEOS)
+  // In Chrome OS let's try to restore the ARC instance if it is available.
+  arc::ArcBridgeService::Get()->SetEnabled(

[sky, 2015/11/10 18:47:11]

Why are you doing this here rather than during browser process startup?

[Luis Héctor Chávez, 2015/11/10 21:03:12]

Are profile preferences available there? I had trouble finding a good spot where
this is available and happens after cryptohome had been mounted. I'm happy to
move this to a better place.

[sky, 2015/11/10 21:39:16]

You may be right. But that begs another question. Shouldn't enabling arc be via
a switch rather than a pref?

[Luis Héctor Chávez, 2015/11/10 21:59:47]

This feature will be opt-in, so we need a pref to start it.

There is also a flag in session_manager that we check to see if it is
available/supported by Chrome OS. To start, it needs to be both available and
enabled.

+      arc::ArcPrefs::GetEnabled(profile_->GetPrefs()));
+  arc::ArcBridgeService::Get()->HandleStartup();

[oshima, 2015/11/10 22:09:03]

how about doing this in ShellObserver::OnLoginStateChanged? You can add observer
in chrome_shell_delegate_chromeos.cc.

[Luis Héctor Chávez, 2015/11/11 17:59:35]

Done.

+#endif
+
   if (pref.type == SessionStartupPref::LAST) {
     if (profile_->GetLastSessionExitType() == Profile::EXIT_CRASHED &&
         !command_line_.HasSwitch(switches::kRestoreLastSession)) {
       // The last session crashed. It's possible automatically loading the
       // page will trigger another crash, locking the user out of chrome.
       // To avoid this, don't restore on startup but instead show the crashed
       // infobar.
       VLOG(1) << "Unclean exit; not processing";
       return false;
     }
@@ skipping 397 matching lines @@
   TriggeredProfileResetter* triggered_profile_resetter =
       TriggeredProfileResetterFactory::GetForBrowserContext(profile_);
   // TriggeredProfileResetter instance will be nullptr for incognito profiles.
   if (triggered_profile_resetter) {
     has_reset_trigger = triggered_profile_resetter->HasResetTrigger();
     triggered_profile_resetter->ClearResetTrigger();
   }
 #endif  // defined(OS_WIN)
   return has_reset_trigger;
 }