arc-bridge: Start ArcBridgeService on session start

chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
 
 #include "ash/accelerators/magnifier_key_scroller.h"
 #include "ash/accelerators/spoken_feedback_toggler.h"
 #include "ash/accessibility_delegate.h"
 #include "ash/wm/mru_window_tracker.h"
@@ skipping 17 matching lines @@
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chrome/browser/ui/ash/media_delegate_chromeos.h"
 #include "chrome/browser/ui/ash/session_state_delegate_chromeos.h"
 #include "chrome/browser/ui/ash/system_tray_delegate_chromeos.h"
 #include "chrome/browser/ui/aura/accessibility/automation_manager_aura.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/chromeos_switches.h"
+#include "components/arc/arc_bridge_service.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "ui/aura/window.h"
 #include "ui/base/ime/chromeos/input_method_manager.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 void InitAfterFirstSessionStart() {
   // Restore focus after the user session is started.  It's needed because some
@@ skipping 170 matching lines @@
       chromeos::switches::kFirstExecAfterBoot);
 }
 
 void ChromeShellDelegate::PreInit() {
   chromeos::LoadDisplayPreferences(IsFirstRunAfterBoot());
   // Set the observer now so that we can save the initial state
   // in Shell::Init.
   display_configuration_observer_.reset(
       new chromeos::DisplayConfigurationObserver());
 
+  arc_session_observer_.reset(new ArcSessionObserver);
+
   chrome_user_metrics_recorder_.reset(new ChromeUserMetricsRecorder);
 }
 
 void ChromeShellDelegate::PreShutdown() {
   display_configuration_observer_.reset();
+  arc_session_observer_.reset();

[sky, 2015/11/12 22:06:53]

Please document why this needs to be shutdown here rather than the scoped_ptr.
It isn't obvious.

[Luis Héctor Chávez, 2015/11/12 22:21:38]

Done.

   chrome_user_metrics_recorder_.reset();
 }
 
 ash::SessionStateDelegate* ChromeShellDelegate::CreateSessionStateDelegate() {
   return new SessionStateDelegateChromeos;
 }
 
 ash::AccessibilityDelegate* ChromeShellDelegate::CreateAccessibilityDelegate() {
   return new AccessibilityDelegateImpl;
 }
@@ skipping 47 matching lines @@
 }
 
 void ChromeShellDelegate::PlatformInit() {
   registrar_.Add(this,
                  chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED,
                  content::NotificationService::AllSources());
   registrar_.Add(this,
                  chrome::NOTIFICATION_SESSION_STARTED,
                  content::NotificationService::AllSources());
 }
+
+ChromeShellDelegate::ArcSessionObserver::ArcSessionObserver() {
+  ash::Shell::GetInstance()->AddShellObserver(this);
+}
+
+ChromeShellDelegate::ArcSessionObserver::~ArcSessionObserver() {
+  ash::Shell::GetInstance()->RemoveShellObserver(this);
+}
+
+void ChromeShellDelegate::ArcSessionObserver::OnLoginStateChanged(
+    ash::user::LoginStatus status) {
+  switch (status) {
+    case ash::user::LOGGED_IN_LOCKED:
+    case ash::user::LOGGED_IN_KIOSK_APP:
+      return;
+
+    case ash::user::LOGGED_IN_NONE:
+      arc::ArcBridgeService::Get()->Shutdown();
+      break;
+
+    case ash::user::LOGGED_IN_USER:
+    case ash::user::LOGGED_IN_OWNER:
+    case ash::user::LOGGED_IN_GUEST:
+    case ash::user::LOGGED_IN_PUBLIC:
+    case ash::user::LOGGED_IN_SUPERVISED:
+      Profile* profile = ProfileManager::GetActiveUserProfile();
+      const bool enabled = arc::ArcPrefs::GetEnabled(
+          profile->GetPrefs(), base::CommandLine::ForCurrentProcess());
+      arc::ArcBridgeService::Get()->SetEnabled(enabled);
+      arc::ArcBridgeService::Get()->HandleStartup();

[oshima, 2015/11/11 22:07:38]

This is a future suggestion, as this requires changes in another CL. Do you
really need separate SetEnabled and HnadleStartup? Can you just call
HandleStartup (Or just StartUp) only when the feature is enabled?

[Luis Héctor Chávez, 2015/11/11 22:11:12]

SetEnabled might change during runtime, so HandleStartup must be called
regardless.

[oshima, 2015/11/11 22:55:30]

It's not clear to me why you need both (SetEnable and HandleStartup/Shutdown),
but we can discuss it in the other CL.

+      break;
+  }
+}