arc-bridge: Start ArcBridgeService on session start

chrome/browser/ui/ash/chrome_shell_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_CHROME_SHELL_DELEGATE_H_
 #define CHROME_BROWSER_UI_ASH_CHROME_SHELL_DELEGATE_H_
 
 #include <string>
 
 #include "ash/shelf/shelf_item_types.h"
 #include "ash/shell_delegate.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
+#if defined(OS_CHROMEOS)
+#include "ash/shell_observer.h"
+#endif
+
 class Browser;
 
 namespace ash {
 class ShelfItemDelegate;
 }
 
 namespace content {
 class WebContents;
 }
 
@@ skipping 66 matching lines @@
 
   base::ObserverList<ash::VirtualKeyboardStateObserver>
       keyboard_state_observer_list_;
 
   // Proxies events from chrome/browser to ash::UserMetricsRecorder.
   scoped_ptr<ChromeUserMetricsRecorder> chrome_user_metrics_recorder_;
 
 #if defined(OS_CHROMEOS)
   scoped_ptr<chromeos::DisplayConfigurationObserver>
       display_configuration_observer_;
+
+  // An Observer to track session state and start/stop ARC accordingly.
+  class ArcSessionObserver : public ash::ShellObserver {

[oshima, 2015/11/11 22:07:38]

move the class definition in .cc file.

[Luis Héctor Chávez, 2015/11/11 22:11:12]

I tried to do that, but if I put it in chrome_shell_delegate.cc, I cannot access
it in chrome_shell_delegate_chromeos.cc. If I put it in the latter, scoped_ptr
complains that the type is not complete when building
chromeos_shell_delegate.cc. I can put it in a separate .h file, if that is
desirable.

[oshima, 2015/11/11 22:55:30]

you can do this

chrome_shell_delegate.h:

class ChromeShellDelegate : .. {
  class ArcSessionObserver;
  scoped_ptr<ArcSessionObserver> arc_session_observer_;
}

then
chrome_shell_dlegate_chromeos.cc

class ChromeShellDelegate::ArcSessionObserver :  {
}

[Luis Héctor Chávez, 2015/11/11 23:41:07]

That's what I tried. Compilation fails in chrome_shell_delegate.cc when trying
to create the shared_ptr due to base/memory/scoped_ptr.h:127 since the type is
not complete (in that file).

[oshima, 2015/11/12 19:09:51]

I see. Too bad given that this will soon be chromeos only. The reason I was
asking is that having private class definition in a header makes little sense.
(we don't use private static member function for the same reason)

We can move this when we consolidate files.

[sky, 2015/11/12 22:06:53]

Move this above other fields. That is, keep all fields grouped together and
don't mix other types in between them.

[Luis Héctor Chávez, 2015/11/12 22:21:38]

Done.

+   public:
+    ArcSessionObserver();
+    ~ArcSessionObserver() override;
+
+    // ash::ShellObserver overrides:
+    void OnLoginStateChanged(ash::user::LoginStatus status) override;
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(ArcSessionObserver);
+  };
+
+  // An Observer to track session state and start/stop ARC accordingly.
+  scoped_ptr<ArcSessionObserver> arc_session_observer_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(ChromeShellDelegate);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_CHROME_SHELL_DELEGATE_H_