Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 14163006: Rename SpecificError to OSError to reflect its source (Closed)

Created:
7 years, 8 months ago by dgrogan
Modified:
7 years, 8 months ago
Reviewers:
jsbell
CC:
chromium-reviews, alecflett
Visibility:
Public.

Description

Rename SpecificError to OSError to reflect its source BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195031

Patch Set 1 #

Patch Set 2 : line wrapping #

Patch Set 3 : ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M third_party/leveldatabase/env_chromium.cc View 1 8 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Josh, could you review this?
7 years, 8 months ago (2013-04-18 22:50:41 UTC) #1
jsbell
lgtm
7 years, 8 months ago (2013-04-18 23:49:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/14163006/6001
7 years, 8 months ago (2013-04-18 23:50:52 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-18 23:52:14 UTC) #4
dgrogan
7 years, 8 months ago (2013-04-19 00:50:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r195031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698