Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 14163004: xcode_emulation: Do not redirect stderr when calling xcodebuild. (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
kal
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

xcode_emulation: Do not redirect stderr when calling xcodebuild. For someone, `xcodebuild -version -sdk macosx10.6 Path` would print 2013-04-12 17:18:59.803 xcodebuild[39147:f07] Error loading /Users/alexisme/Library/Developer/Xcode/Third-Party Plug-ins/CodePilot2.xcplugin/Contents/MacOS/CodePilot2: dlopen(/Users/alexisme/Library/Developer/Xcode/Third-Party Plug-ins/CodePilot2.xcplugin/Contents/MacOS/CodePilot2, 265): Symbol not found: _IDEEditorDocumentDidChangeNotification Referenced from: /Users/alexisme/Library/Developer/Xcode/Third-Party Plug-ins/CodePilot2.xcplugin/Contents/MacOS/CodePilot2 Expected in: flat namespace in /Users/alexisme/Library/Developer/Xcode/Third-Party Plug-ins/CodePilot2.xcplugin/Contents/MacOS/CodePilot2 2013-04-12 17:18:59.804 xcodebuild[39147:f07] WARNING: Failed to load plugin at: /Users/alexisme/Library/Developer/Xcode/Third-Party Plug-ins/CodePilot2.xcplugin, skipping. Could not load bundle. to stderr. This was captured too and got added to the sdk path, which caused a hard-to-understand exception later one. There's no reason to redirect stderr, just let it print to the console instead. Committed: https://code.google.com/p/gyp/source/detail?r=1611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 8 months ago (2013-04-12 22:31:30 UTC) #1
kal
lgtm
7 years, 8 months ago (2013-04-12 23:12:09 UTC) #2
Nico
7 years, 8 months ago (2013-04-12 23:27:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698