Fix some unit tests that fail when we enable impl property trees

Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting.

BUG=551629
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8640f9f594fd67ae0013824663b789f66895f7a4
Cr-Commit-Position: refs/heads/master@{#358733}

[jaydasika, 2015-11-09 22:07:19]

Description was changed from

==========
[WIP] Fix unit tests
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting. 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2015-11-09 22:07:47]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2015-11-09 22:09:01]

Description was changed from

==========
Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting. 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting. 
BUG=551629
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2015-11-09 22:09:59]

Description was changed from

==========
Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting. 
BUG=551629
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix some unit tests that fail when we enable impl property trees

This patch fixes some unit tests that fail when we set the
default value of 'use_property_trees' to true for
CalcDrawPropsImplInputsForTesting.

BUG=551629
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2015-11-09 22:12:45]

On 2015/11/09 22:07:48, jaydasika wrote:

This patch has all the trivial fixes. There are ~8 more unittests to be fixed,
and I think each of them needs to be handled separately.

[ajuma, 2015-11-09 23:17:19]

lgtm with a couple nits.

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (left):

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:1258: EXPECT_EQ(gfx::Rect(0, 0, 10,
10), parent->drawable_content_rect());
Just to make sure, is this line removed because making the parent draw content
(causing it to have draw properties computed) would change the scenario this is
trying to test? Can we instead check the root render surface's drawable content
rect?

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:3458: // Layers that do not draw
content should have empty visible content rects.
Nit (here and once more below): no need to remove the punctuation on this line.

[jaydasika, 2015-11-09 23:27:58]

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (left):

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:1258: EXPECT_EQ(gfx::Rect(0, 0, 10,
10), parent->drawable_content_rect());
On 2015/11/09 23:17:19, ajuma (slow till Nov. 16) wrote:
> Just to make sure, is this line removed because making the parent draw content
> (causing it to have draw properties computed) would change the scenario this
is
> trying to test? Can we instead check the root render surface's drawable
content
> rect?

Yes, making parent draw content will change what this test is trying to test.
And yes, we can check the surface's drawable content rect.

https://codereview.chromium.org/1416293005/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:3458: // Layers that do not draw
content should have empty visible content rects.
On 2015/11/09 23:17:19, ajuma (slow till Nov. 16) wrote:
> Nit (here and once more below): no need to remove the punctuation on this
line.

Done.

[jaydasika, 2015-11-10 00:43:19]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2015-11-10 00:43:19]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1416293005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-10 00:44:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416293005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416293005/40001

[commit-bot: I haz the power, 2015-11-10 01:34:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-10 01:35:41]

Patchset 3 (id:??) landed as
https://crrev.com/8640f9f594fd67ae0013824663b789f66895f7a4
Cr-Commit-Position: refs/heads/master@{#358733}