Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1416293004: Revert of [turbofan] Remove redundant code. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Mircea Trofin, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Remove redundant code. (patchset #1 id:1 of https://codereview.chromium.org/1428943004/ ) Reason for revert: This CL reintroduces all kinds of funny moves for Merges of deferred code, which makes jump threading ineffective. Original issue's description: > [turbofan] Remove redundant code. > > When I centralized the treatment of memory operands, I forgot to delete > the old code. > > There is a semantic difference between the old and new code. The old > code was handling either memory operands, or ranges that had a spilled > predecessor. The new code handles just memory operands. It may > happen that (using LinearScan) an active range is spilled when trying > to allocate another range (see SplitAndSpillIntersecting). That may make > it a candidate for the old version of the code, however, since we would > have spilled up to a register use, the old code wouldn't have had taken > effect. > > Perf data shows this nuance doesn't make a difference in perf. > > BUG= > > Committed: https://crrev.com/c03d7a7f03657a452f71277d84e435ed73566327 > Cr-Commit-Position: refs/heads/master@{#31729} TBR=jarin@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5f4828a12db3f04f8b92f10724c5c18dd5efc7e7 Cr-Commit-Position: refs/heads/master@{#31732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [turbofan] Remove redundant code.
5 years, 1 month ago (2015-11-03 07:41:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416293004/1
5 years, 1 month ago (2015-11-03 07:42:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 07:42:11 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 07:42:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f4828a12db3f04f8b92f10724c5c18dd5efc7e7
Cr-Commit-Position: refs/heads/master@{#31732}

Powered by Google App Engine
This is Rietveld 408576698