Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1416283002: Merge to XFA: Remove unused CPDFSDK_InterForm::DoFDFBuffer. (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove unused CPDFSDK_InterForm::DoFDFBuffer. This method isn't used anywhere and the implementation doesn't really do anything. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1405163003 . (cherry picked from commit 162f227af9c5e28885a36e6ca06a09c12c6223e0) Committed: https://pdfium.googlesource.com/pdfium/+/b57b4ad6daa32b8522c0ac5bb9d50451eb1f8469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
TBRing, merge clean.
5 years, 2 months ago (2015-10-22 15:13:50 UTC) #1
dsinclair
Committed patchset #1 (id:1) manually as b57b4ad6daa32b8522c0ac5bb9d50451eb1f8469 (presubmit successful).
5 years, 2 months ago (2015-10-22 15:14:00 UTC) #2
Lei Zhang
5 years, 2 months ago (2015-10-22 16:09:05 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698