Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: src/heap/gc-tracer.cc

Issue 1416273003: [heap] Do not print isoalte address twice in --trace-gc-nvp. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-tracer.cc
diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc
index 56f9b43a3ff49bf0f5e91eb5f1d4b1a78125a568..231c4e9c8d76f15d6d9cb5d2b40f74cfdb8b7644 100644
--- a/src/heap/gc-tracer.cc
+++ b/src/heap/gc-tracer.cc
@@ -401,7 +401,7 @@ void GCTracer::PrintNVP() const {
switch (current_.type) {
case Event::SCAVENGER:
PrintIsolate(heap_->isolate(),
- "[I:%p] %8.0f ms: "
+ "%8.0f ms: "
"pause=%.1f "
"mutator=%.1f "
"gc=%s "
@@ -415,14 +415,22 @@ void GCTracer::PrintNVP() const {
"object_groups=%.2f "
"steps_count=%d "
"steps_took=%.1f "
- "scavenge_throughput=%" V8_PTR_PREFIX "d "
- "total_size_before=%" V8_PTR_PREFIX "d "
- "total_size_after=%" V8_PTR_PREFIX "d "
- "holes_size_before=%" V8_PTR_PREFIX "d "
- "holes_size_after=%" V8_PTR_PREFIX "d "
- "allocated=%" V8_PTR_PREFIX "d "
- "promoted=%" V8_PTR_PREFIX "d "
- "semi_space_copied=%" V8_PTR_PREFIX "d "
+ "scavenge_throughput=%" V8_PTR_PREFIX
+ "d "
+ "total_size_before=%" V8_PTR_PREFIX
+ "d "
+ "total_size_after=%" V8_PTR_PREFIX
+ "d "
+ "holes_size_before=%" V8_PTR_PREFIX
+ "d "
+ "holes_size_after=%" V8_PTR_PREFIX
+ "d "
+ "allocated=%" V8_PTR_PREFIX
+ "d "
+ "promoted=%" V8_PTR_PREFIX
+ "d "
+ "semi_space_copied=%" V8_PTR_PREFIX
+ "d "
"nodes_died_in_new=%d "
"nodes_copied_in_new=%d "
"nodes_promoted=%d "
@@ -430,13 +438,11 @@ void GCTracer::PrintNVP() const {
"average_survival_ratio=%.1f%% "
"promotion_rate=%.1f%% "
"semi_space_copy_rate=%.1f%% "
- "new_space_allocation_throughput=%" V8_PTR_PREFIX "d "
+ "new_space_allocation_throughput=%" V8_PTR_PREFIX
+ "d "
"context_disposal_rate=%.1f\n",
- heap_->isolate(),
- heap_->isolate()->time_millis_since_init(),
- duration,
- spent_in_mutator,
- current_.TypeName(true),
+ heap_->isolate()->time_millis_since_init(), duration,
+ spent_in_mutator, current_.TypeName(true),
current_.reduce_memory,
current_.scopes[Scope::SCAVENGER_SCAVENGE],
current_.scopes[Scope::SCAVENGER_OLD_TO_NEW_POINTERS],
@@ -462,7 +468,7 @@ void GCTracer::PrintNVP() const {
case Event::MARK_COMPACTOR:
case Event::INCREMENTAL_MARK_COMPACTOR:
PrintIsolate(heap_->isolate(),
- "[I:%p] %8.0f ms: "
+ "%8.0f ms: "
"pause=%.1f "
"mutator=%.1f "
"gc=%s "
@@ -528,8 +534,8 @@ void GCTracer::PrintNVP() const {
"new_space_allocation_throughput=%" V8_PTR_PREFIX
"d "
"context_disposal_rate=%.1f\n",
- heap_->isolate(), heap_->isolate()->time_millis_since_init(),
- duration, spent_in_mutator, current_.TypeName(true),
+ heap_->isolate()->time_millis_since_init(), duration,
+ spent_in_mutator, current_.TypeName(true),
current_.reduce_memory, current_.scopes[Scope::EXTERNAL],
current_.scopes[Scope::MC_MARK],
current_.scopes[Scope::MC_MARK_FINISH_INCREMENTAL],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698