 Chromium Code Reviews
 Chromium Code Reviews Issue 1416273002:
  Remove SVGPathElement.pathSegList and related interfaces  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1416273002:
  Remove SVGPathElement.pathSegList and related interfaces  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 <?xml version="1.0" encoding="UTF-8"?> | 1 <?xml version="1.0" encoding="UTF-8"?> | 
| 2 <svg xmlns="http://www.w3.org/2000/svg" onload="runTest()"> | 2 <svg xmlns="http://www.w3.org/2000/svg" onload="runTest()"> | 
| 3 <script type="text/ecmascript"><![CDATA[ | 3 <script type="text/ecmascript"><![CDATA[ | 
| 4 if (window.testRunner) | 4 if (window.testRunner) | 
| 5 testRunner.dumpAsText(); | 5 testRunner.dumpAsText(); | 
| 6 | 6 | 
| 7 function expect(string, val) { | 7 function expect(string, val) { | 
| 8 var b = eval(string) == val; | 8 var b = eval(string) == val; | 
| 9 var message = (string + "") + " " + (b ? "PASSED" : "FAILED (actual: '" + eval(string) + "' expected: '" + val + "')"); | 9 var message = (string + "") + " " + (b ? "PASSED" : "FAILED (actual: '" + eval(string) + "' expected: '" + val + "')"); | 
| 10 var txt = document.createElementNS("http://www.w3.org/2000/svg", "text"); | 10 var txt = document.createElementNS("http://www.w3.org/2000/svg", "text"); | 
| (...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 115 expect("SVGLength.SVG_LENGTHTYPE_PT", 9); | 115 expect("SVGLength.SVG_LENGTHTYPE_PT", 9); | 
| 116 expect("SVGLength.SVG_LENGTHTYPE_PC", 10) | 116 expect("SVGLength.SVG_LENGTHTYPE_PC", 10) | 
| 117 | 117 | 
| 118 expect("SVGMarkerElement.SVG_MARKERUNITS_UNKNOWN", 0); | 118 expect("SVGMarkerElement.SVG_MARKERUNITS_UNKNOWN", 0); | 
| 119 expect("SVGMarkerElement.SVG_MARKERUNITS_USERSPACEONUSE", 1); | 119 expect("SVGMarkerElement.SVG_MARKERUNITS_USERSPACEONUSE", 1); | 
| 120 expect("SVGMarkerElement.SVG_MARKERUNITS_STROKEWIDTH", 2); | 120 expect("SVGMarkerElement.SVG_MARKERUNITS_STROKEWIDTH", 2); | 
| 121 expect("SVGMarkerElement.SVG_MARKER_ORIENT_UNKNOWN", 0); | 121 expect("SVGMarkerElement.SVG_MARKER_ORIENT_UNKNOWN", 0); | 
| 122 expect("SVGMarkerElement.SVG_MARKER_ORIENT_AUTO", 1); | 122 expect("SVGMarkerElement.SVG_MARKER_ORIENT_AUTO", 1); | 
| 123 expect("SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE", 2); | 123 expect("SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE", 2); | 
| 124 | 124 | 
| 125 expect("SVGPathSeg.PATHSEG_UNKNOWN", 0); | 125 expect_failure("SVGPathSeg.PATHSEG_UNKNOWN", 0); | 
| 
pdr.
2015/10/23 04:40:55
Just remove these? (similar for js-svg-constructor
 
fs
2015/10/23 09:12:32
Sure. Done (w/ collateral damage in the form of re
 | |
| 126 expect("SVGPathSeg.PATHSEG_CLOSEPATH", 1); | 126 expect_failure("SVGPathSeg.PATHSEG_CLOSEPATH", 1); | 
| 127 expect("SVGPathSeg.PATHSEG_MOVETO_ABS", 2); | 127 expect_failure("SVGPathSeg.PATHSEG_MOVETO_ABS", 2); | 
| 128 expect("SVGPathSeg.PATHSEG_MOVETO_REL", 3); | 128 expect_failure("SVGPathSeg.PATHSEG_MOVETO_REL", 3); | 
| 129 expect("SVGPathSeg.PATHSEG_LINETO_ABS", 4); | 129 expect_failure("SVGPathSeg.PATHSEG_LINETO_ABS", 4); | 
| 130 expect("SVGPathSeg.PATHSEG_LINETO_REL", 5); | 130 expect_failure("SVGPathSeg.PATHSEG_LINETO_REL", 5); | 
| 131 expect("SVGPathSeg.PATHSEG_CURVETO_CUBIC_ABS", 6); | 131 expect_failure("SVGPathSeg.PATHSEG_CURVETO_CUBIC_ABS", 6); | 
| 132 expect("SVGPathSeg.PATHSEG_CURVETO_CUBIC_REL", 7); | 132 expect_failure("SVGPathSeg.PATHSEG_CURVETO_CUBIC_REL", 7); | 
| 133 expect("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_ABS", 8); | 133 expect_failure("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_ABS", 8); | 
| 134 expect("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_REL", 9); | 134 expect_failure("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_REL", 9); | 
| 135 expect("SVGPathSeg.PATHSEG_ARC_ABS", 10); | 135 expect_failure("SVGPathSeg.PATHSEG_ARC_ABS", 10); | 
| 136 expect("SVGPathSeg.PATHSEG_ARC_REL", 11); | 136 expect_failure("SVGPathSeg.PATHSEG_ARC_REL", 11); | 
| 137 expect("SVGPathSeg.PATHSEG_LINETO_HORIZONTAL_ABS", 12); | 137 expect_failure("SVGPathSeg.PATHSEG_LINETO_HORIZONTAL_ABS", 12); | 
| 138 expect("SVGPathSeg.PATHSEG_LINETO_HORIZONTAL_REL", 13); | 138 expect_failure("SVGPathSeg.PATHSEG_LINETO_HORIZONTAL_REL", 13); | 
| 139 expect("SVGPathSeg.PATHSEG_LINETO_VERTICAL_ABS", 14); | 139 expect_failure("SVGPathSeg.PATHSEG_LINETO_VERTICAL_ABS", 14); | 
| 140 expect("SVGPathSeg.PATHSEG_LINETO_VERTICAL_REL", 15); | 140 expect_failure("SVGPathSeg.PATHSEG_LINETO_VERTICAL_REL", 15); | 
| 141 expect("SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_ABS", 16); | 141 expect_failure("SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_ABS", 16); | 
| 142 expect("SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_REL", 17); | 142 expect_failure("SVGPathSeg.PATHSEG_CURVETO_CUBIC_SMOOTH_REL", 17); | 
| 143 expect("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS", 18); | 143 expect_failure("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS", 18); | 
| 144 expect("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_SMOOTH_REL", 19); | 144 expect_failure("SVGPathSeg.PATHSEG_CURVETO_QUADRATIC_SMOOTH_REL", 19); | 
| 145 | 145 | 
| 146 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_UNKNOWN", 0); | 146 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_UNKNOWN", 0); | 
| 147 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_NONE", 1); | 147 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_NONE", 1); | 
| 148 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN", 2); | 148 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN", 2); | 
| 149 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN", 3); | 149 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN", 3); | 
| 150 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN", 4); | 150 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN", 4); | 
| 151 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMID", 5); | 151 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMID", 5); | 
| 152 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID", 6); | 152 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID", 6); | 
| 153 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID", 7); | 153 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID", 7); | 
| 154 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX", 8); | 154 expect("SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX", 8); | 
| (...skipping 25 matching lines...) Expand all Loading... | |
| 180 expect("SVGUnitTypes.SVG_UNIT_TYPE_UNKNOWN", 0); | 180 expect("SVGUnitTypes.SVG_UNIT_TYPE_UNKNOWN", 0); | 
| 181 expect("SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE", 1); | 181 expect("SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE", 1); | 
| 182 expect("SVGUnitTypes.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX", 2); | 182 expect("SVGUnitTypes.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX", 2); | 
| 183 | 183 | 
| 184 expect("SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN", 0); | 184 expect("SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN", 0); | 
| 185 expect("SVGViewElement.SVG_ZOOMANDPAN_DISABLE", 1); | 185 expect("SVGViewElement.SVG_ZOOMANDPAN_DISABLE", 1); | 
| 186 expect("SVGViewElement.SVG_ZOOMANDPAN_MAGNIFY", 2); | 186 expect("SVGViewElement.SVG_ZOOMANDPAN_MAGNIFY", 2); | 
| 187 } | 187 } | 
| 188 ]]></script> | 188 ]]></script> | 
| 189 </svg> | 189 </svg> | 
| OLD | NEW |