Remove requiredTypes

Remove requiredTypes

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/58a11d1077a841c34a5a470150e8be2a3ba4f8f8

[Johnni Winther, 2015-10-22 08:55:46]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-10-22 08:55:46]

Main changes in deferred_load.dart and js_backend/backend.dart

[sigurdm, 2015-10-22 09:18:03]

LGTM

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:3002: void
registerRequiredType(DartType type) {
Could use comment. What is a "required" type?

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_impact.dart:155: instantiatedClasses: [
Formatting looks weird

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (left):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4662: doInCheckContext(() =>
visitIn(node.type, blockScope));
doInCheckContext seems to be unused now.

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_impact.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:57: }
empty line between members

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:58: static void
printOn(StringBuffer sb, WorldImpact worldImpact) {
Why is this static?

[Johnni Winther, 2015-10-22 10:31:56]

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:3002: void
registerRequiredType(DartType type) {
On 2015/10/22 09:18:03, sigurdm wrote:
> Could use comment. What is a "required" type?

Required for RTI. Added a doc comment.

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_impact.dart:155: instantiatedClasses: [
On 2015/10/22 09:18:03, sigurdm wrote:
> Formatting looks weird

But consistent through-out the file. The formatting was chosen to make the
dependencies read more clearly.

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (left):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4662: doInCheckContext(() =>
visitIn(node.type, blockScope));
On 2015/10/22 09:18:03, sigurdm wrote:
> doInCheckContext seems to be unused now.

Good catch! Removed.

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_impact.dart (right):

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:57: }
On 2015/10/22 09:18:03, sigurdm wrote:
> empty line between members

Done.

https://codereview.chromium.org/1416253002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:58: static void
printOn(StringBuffer sb, WorldImpact worldImpact) {
On 2015/10/22 09:18:03, sigurdm wrote:
> Why is this static?

So it can be required between for subclasses and subinterfaces.

[Johnni Winther, 2015-10-22 10:52:12]

Committed patchset #2 (id:20001) manually as
58a11d1077a841c34a5a470150e8be2a3ba4f8f8 (presubmit successful).