Move both dynamic and static object body visiting logic to BodyDescriptorBase class.

Move both dynamic and static object body visiting logic to BodyDescriptorBase class.

Committed: https://crrev.com/e8cab885ed0d32ba03f0b5ed6be5548d036d79d8
Cr-Commit-Position: refs/heads/master@{#31829}

[Igor Sheludko, 2015-11-04 19:41:10]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-11-04 19:41:21]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 19:41:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416243009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416243009/20001

[Igor Sheludko, 2015-11-04 19:56:03]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2015-11-04 19:56:04]

PTAL

[commit-bot: I haz the power, 2015-11-04 20:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:10:07]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-11-05 13:10:25]

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h#newcode1640
src/objects.h:1640: // This class base class for object's body descriptors.
nit: "This is the base class ..."?

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h#newcode1677
src/objects.h:1677: class FlexibleBodyDescriptorBase : public BodyDescriptorBase
{
Is there a particular reason FlexibleBodyDescriptorBase and
FlexibleBodyDescriptor have to be separate classes? Could we just merge them
into FlexibleBodyDescriptor instead?

[Michael Starzinger, 2015-11-05 13:44:46]

LGTM. I like it.

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h#newcode1677
src/objects.h:1677: class FlexibleBodyDescriptorBase : public BodyDescriptorBase
{
On 2015/11/05 13:10:25, Michael Starzinger wrote:
> Is there a particular reason FlexibleBodyDescriptorBase and
> FlexibleBodyDescriptor have to be separate classes? Could we just merge them
> into FlexibleBodyDescriptor instead?

As discussed offline: This is used by FixedArray::BodyDescriptor, didn't see
that before. It's fine then. Please disregard this comment.

[Igor Sheludko, 2015-11-05 13:45:13]

Thanks!

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h#newcode1640
src/objects.h:1640: // This class base class for object's body descriptors.
On 2015/11/05 13:10:25, Michael Starzinger wrote:
> nit: "This is the base class ..."?

Done.

https://codereview.chromium.org/1416243009/diff/20001/src/objects.h#newcode1677
src/objects.h:1677: class FlexibleBodyDescriptorBase : public BodyDescriptorBase
{
On 2015/11/05 13:10:25, Michael Starzinger wrote:
> Is there a particular reason FlexibleBodyDescriptorBase and
> FlexibleBodyDescriptor have to be separate classes? Could we just merge them
> into FlexibleBodyDescriptor instead?

I tried to avoid the confusion, since the FixedArray::BodyDescriptor defines
it's own SizeOf() method. So FixedArray::BodyDescriptor inherits from the
FlexibleBodyDescriptorBase which does not have a SizeOf().

[Igor Sheludko, 2015-11-05 13:45:23]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-11-05 13:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416243009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416243009/40001

[commit-bot: I haz the power, 2015-11-05 14:02:40]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-05 14:03:00]

Patchset 2 (id:??) landed as
https://crrev.com/e8cab885ed0d32ba03f0b5ed6be5548d036d79d8
Cr-Commit-Position: refs/heads/master@{#31829}