Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1416243007: [cleanup] Merge harmony-{typed,}array.js into {typed,}array.js (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Merge harmony-{typed,}array.js into {typed,}array.js The "harmony"-prefixed files have been included in the snapshot for several releases now, and were only separate originally to enable loading them via a runtime flag. This patch simply merges them into the main implementation files for Arrays and TypedArrays, respectively. Committed: https://crrev.com/4edbe3ac0fa6e470f18af2219aa1382f1ea505d1 Cr-Commit-Position: refs/heads/master@{#31767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -728 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/array.js View 9 chunks +269 lines, -2 lines 0 comments Download
D src/js/harmony-array.js View 1 chunk +0 lines, -304 lines 0 comments Download
D src/js/harmony-typedarray.js View 1 chunk +0 lines, -416 lines 0 comments Download
M src/js/typedarray.js View 4 chunks +377 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Only sad thing about this change is adding one more hurdle for git blame, but ...
5 years, 1 month ago (2015-11-04 00:10:26 UTC) #2
Dan Ehrenberg
lgtm
5 years, 1 month ago (2015-11-04 00:16:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416243007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416243007/1
5 years, 1 month ago (2015-11-04 00:24:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 01:07:44 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 01:08:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4edbe3ac0fa6e470f18af2219aa1382f1ea505d1
Cr-Commit-Position: refs/heads/master@{#31767}

Powered by Google App Engine
This is Rietveld 408576698