Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1416243004: Add documentation to typed-list .fromList constructors saying that values are truncated. (Closed)

Created:
5 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add documentation to typed-list .fromList constructors saying that values are truncated. Fixes issue #24708. BUG= http://dartbug.com/24708 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/d9a4022ab981654e1d988275105aaebb375ef9bd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -35 lines) Patch
M sdk/lib/typed_data/typed_data.dart View 45 chunks +65 lines, -35 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-10-26 10:19:46 UTC) #2
floitsch
LGTM.
5 years, 1 month ago (2015-10-26 10:21:12 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as d9a4022ab981654e1d988275105aaebb375ef9bd (presubmit successful).
5 years, 1 month ago (2015-10-26 10:22:05 UTC) #4
sra1
5 years, 1 month ago (2015-10-26 16:42:22 UTC) #6
Message was sent while issue was closed.
DBC

https://codereview.chromium.org/1416243004/diff/1/sdk/lib/typed_data/typed_da...
File sdk/lib/typed_data/typed_data.dart (right):

https://codereview.chromium.org/1416243004/diff/1/sdk/lib/typed_data/typed_da...
sdk/lib/typed_data/typed_data.dart:737: * the same way `operator[]` truncates
values.
operator[]=

Where is this truncation behaviour described?
Can this be phrased to contain a link to that place?

Consider describing the truncation behaviour in the class comment. Otherwise you
need to add abstract members just as somewhere to add documentation (not
necessarily a bad thing).  E.g. the same is true of setRange.

Powered by Google App Engine
This is Rietveld 408576698